Zhou Zheng Sheng has posted comments on this change.
Change subject: Handling errors in daemonAdapter
......................................................................
Patch Set 7:
(2 comments)
....................................................
File init/daemonAdapter
Line 25:
Line 26: from vdsm.config import config
Line 27:
Line 28:
Line 29: class DaemonAdapter:
I think it's better to have DaemonAdapter(object) .
Line 30: def __init__(self):
Line 31: self._args = None
Line 32: self._parse_args()
Line 33: self._log = None
....................................................
File init/sysvinit/vdsmd.init.in
Line 141: "${VDSMD_INIT_COMMON}" --pre-start
Line 142:
Line 143: echo $"Starting up vdsm daemon: "
Line 144: NICELEVEL="${NICE_LOWEST}" daemon --user=vdsm
"@VDSMDIR@/daemonAdapter" \
Line 145: -0 /dev/null -1 /dev/null -2 /dev/null --lockfile
"${LOCK_FILE}" --syslog "@VDSMDIR@/respawn" --minlifetime 10 \
I see in daemonAdapter, --lockfile is removed. Here it should be removed too.
Line 146: --daemon --masterpid "${RESPAWNPIDFILE}" "${VDSM_BIN}"
--pidfile "${PIDFILE}"
Line 147: RETVAL=$?
Line 148: [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" ||
log_failure_msg $"$prog start"
Line 149: return "$RETVAL"
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
