Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
......................................................................
Patch Set 6:
(3 comments)
....................................................
File init/sysvinit/vdsmd.init.in
Line 26: GETCONFITEM="@VDSMDIR@/get-conf-item"
Line 27: prog=vdsm
Line 28: PIDFILE=@VDSMRUNDIR@/vdsmd.pid
Line 29: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid
Line 30: INITPIDFILE=@VDSMRUNDIR@/init.pid
why not use the RESPAWNPIDFILE? we must have this filled with respawn pid so
lock will work.
oh... I do understand... but still another pid result in changing the other
file for some reason.
Line 31: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump"
Line 32: CORE_PATTERN="/proc/sys/kernel/core_pattern"
Line 33: LOCK_FILE="/var/lock/subsys/vdsmd"
Line 34: NEEDED_SERVICES="iscsid multipathd rpcbind ntpd wdmd sanlock network
libvirtd
Line 76: {
Line 77: flock --nonblock --exclusive 9 || fail_op
Line 78: local initpid="$(cat "${INITPIDFILE}")"
Line 79: if [ -n "${initpid}" ]; then
Line 80: kill -0 "${initpid}" >/dev/null && fail_op
2> ? 2>&1?
Line 81: fi
Line 82: echo $$ > "${INITPIDFILE}"
Line 83: } 9<"${LOCK_FILE}"
Line 84: }
Line 174: start
Line 175: RETVAL=$?
Line 176: ;;
Line 177: stop)
Line 178: check_running_operation
why do this on stop and not only on start?
Line 179: stop
Line 180: RETVAL=$?
Line 181: ;;
Line 182: status)
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
