Zhou Zheng Sheng has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock ......................................................................
Patch Set 3: (1 comment) .................................................... File configure.ac Line 58: AC_ARG_ENABLE( Line 59: [libvirt-sanlock], Line 60: [AS_HELP_STRING( Line 61: [--disable-libvirt-sanlock], Line 62: [disable libvirt sanlock plugin, enabled by default] I examine the source code of following packages. util-linux: https://www.kernel.org/pub/linux/utils/util-linux/v2.23/util-linux-2.23.tar.xz nfs-utils: https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.8/nfs-utils-1.2.8.tar.xz git: yumdownloader --source git gcc: yumdownloader --source gcc By ./configure --help, I see help string like follow. --enable-xxx[=VALUE] plain English [default=yes] --enable-xxx[=VALUE] plain English explain what's the default value --disable-xxx plain English explanation. I can not find any --disable-xxx plain English [default=value] I notice that for a "--disable-xxx" option, these packages neither explain the default value in Englush nor explain it in "[default=value]" convention. It is only accepted that "--disable-xxx" equals to "--enable-xxx=no". I think these packages are good enough. So I still think we use either --enable-libvirt-sanlock configure libvirt sanlock plugin [default=yes] or --disable-libvirt-sanlock disable libvirt sanlock plugin Agree? Line 63: )], Line 64: , Line 65: [enable_libvirt_sanlock="yes"] Line 66: ) -- To view, visit http://gerrit.ovirt.org/19005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
