Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
......................................................................
Patch Set 6:
(2 comments)
....................................................
File lib/vdsm/tool/libvirt_configure.py
Line 73: if '-h' in args:
Line 74: sys.stdout.write("To start working after reconfigure run:\n"
Line 75: "vdsm-tool reconfigure-restart\n"
Line 76: "This will manage stop and start to the
services: \n"
Line 77: "libvirtd, supervdsmd\n")
again, I don't think this help belongs here but when actually required (for
example as output of vdsm-tool libvirt-reconfigure).
Line 78: return 1
Line 79:
Line 80: service.service_stop("supervdsmd")
Line 81: service.service_stop("libvirtd")
....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 282: ovirt_store_config "${lconf}" "${qconf}" "${ldconf}"
"${llogr}"
Line 283: fi
Line 284:
Line 285: echo "Reconfigure libvirt is done."
Line 286: /bin/vdsm-tool libvirt-configure-services-restart -h
not sure why this should be here...
Line 287:
Line 288:
Line 289: #
Line 290: # finished reconfiguration, do not trigger
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
