Federico Simoncelli has uploaded a new change for review.

Change subject: blockVolume: round up volume size for createVolume
......................................................................

blockVolume: round up volume size for createVolume

The logical volume size granularity used in lvm(.py) is 1Mb, therefore
the size in sectors should be aligned. When the size is particularly
small this also prevents failing lvcreate calls with size 0m.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009086
Change-Id: I5ae3d918ea4e7ca91383c3a3184a338cb40c4c27
Signed-off-by: Federico Simoncelli <fsimo...@redhat.com>
---
M vdsm/storage/blockVolume.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/19390/1

diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 88632ef..badf2c1 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -174,7 +174,7 @@
         if preallocate == volume.SPARSE_VOL:
             volSize = "%s" % config.get("irs", "volume_utilization_chunk_mb")
         else:
-            volSize = "%s" % (size / 2 / 1024)
+            volSize = "%s" % ((size + SECTORS_TO_MB - 1) / SECTORS_TO_MB)
 
         lvm.createLV(dom.sdUUID, volUUID, volSize, activate=True,
                      initialTag=TAG_VOL_UNINIT)


-- 
To view, visit http://gerrit.ovirt.org/19390
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ae3d918ea4e7ca91383c3a3184a338cb40c4c27
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to