Yaniv Bronhaim has posted comments on this change.
Change subject: java_bindings: Minor imporovements
......................................................................
Patch Set 11:
(4 comments)
minor comments. please response
....................................................
Commit Message
Line 5: CommitDate: 2013-08-12 14:23:56 +0300
Line 6:
Line 7: java_bindings: Minor imporovements
Line 8:
Line 9: - Move more code to a common location
did you move something? I haven't seen, maybe you added more or less
indentations
Line 10: - Make it so that calls don't throw an exception if it fails to connect
Line 11: to the server. Instead they return an error through the regular
Line 12: json-rpc mechanism.
Line 13:
....................................................
File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMClientBase.java
Line 24: return _transport.closed();
Line 25: }
Line 26:
Line 27: protected <T> Future<VDSMResponse<T>> _call(RequestBuilder rb,
Line 28: VDSMObject.TypeAdapter<T> rtypeAdapter) {
spaces..
Line 29:
Line 30: final JsonRpcRequest __req = rb.build();
Line 31: final Future<JsonRpcResponse> __call =
_transport.call(__req);
Line 32: return new FutureResultWrapper<>(
....................................................
File
client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMTransportProvider.java
Line 92: request.id());
Line 93:
Line 94: }
Line 95: });
Line 96: fakeTask.run();
no report about the timeout ? only futureTask with response?
Line 97: return fakeTask;
Line 98: }
Line 99:
Line 100: return client.call(request);
Line 101: }
Line 102:
Line 103: public Future<List<JsonRpcResponse>> batchCall(
Line 104: List<JsonRpcRequest> requests)
Line 105: throws TimeoutException {
it was more readable the way the indentation was..
Line 106: final JsonRpcClient client = getClient();
Line 107: return client.batchCall(requests);
Line 108: }
Line 109:
--
To view, visit http://gerrit.ovirt.org/14821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ceb7f58122accf6c911120b99b87d38b656e8e4
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
