Yaniv Bronhaim has posted comments on this change. Change subject: Removing redundant code that reads the pools list ......................................................................
Patch Set 1: (1 comment) .................................................... File vdsm/storage/hsm.py Line 2099: want to check it's tasks. Line 2100: :type spUUID: UUID (deprecated) Line 2101: :options: ? Line 2102: """ Line 2103: # getSharedLock(tasksResource...) check the bz - anyhow, in any way you look at it, checking the first cell in pools doesn't mean anything. the only thing that was needed is using sp for that. The function is under @secured decorator and that takes care of what we want (SPM only api) Line 2104: allTasksStatus = sp.getAllTasksStatuses() Line 2105: return dict(allTasksStatus=allTasksStatus) Line 2106: Line 2107: @public -- To view, visit http://gerrit.ovirt.org/18843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27c74956a9304dfaa2c0f6badf8fdbd2ea02a5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
