Dan Kenigsberg has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/vm.py
Line 3126: link = xml.dom.minidom.Element('link')
Line 3127: vnicXML.appendChildWithArgs(link)
Line 3128: link.setAttribute('state', linkValue)
Line 3129: if specParams and \
Line 3130: ('inbound' in specParams or 'outbound' in
specParams):
Oh, and please document your decision in the commit message.
Line 3131: new_bandwidth = dev.getXmlBandwidth(specParams)
Line 3132: try:
Line 3133: old_bandwidth =
vnicXML.getElementsByTagName('bandwidth')[0]
Line 3134: vnicXML.replaceChild(new_bandwidth, old_bandwidth)
--
To view, visit http://gerrit.ovirt.org/19545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
