Michal Skrivanek has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/vm.py
Line 508: capacity, alloc, physical = \
Line 509: self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510:
Line 511: if physical - alloc < 0:
Line 512: self._vm.pause(pauseCode='EOTHER')
wouldn't EIO be more appropriate here?
Line 513: self._log.error('vm: %s paused due to the corrupt
volume: %s',
Line 514: self._vm.id, vmDrive.path)
Line 515: continue
Line 516:
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
