Yeela Kaplan has posted comments on this change.
Change subject: Enable VM migration to old vdsm's.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1035: try:
Line 1036: os.symlink(imgPath, dst)
Line 1037: except OSError as e:
Line 1038: if e.errno == errno.EEXIST:
Line 1039: self.log.debug("img run dir already exists: %s", dst)
Not readable.
Elaborate on what is img run vol.
Line 1040: else:
Line 1041: self.log.error("Failed to create img run dir: %s",
dst)
Line 1042: raise
Line 1043: return dst
....................................................
File vdsm/storage/hsm.py
Line 3229: allVols = dom.getAllVolumes()
Line 3230: # Filter volumes related to this image
Line 3231: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 3232: imgPath = dom.activateVolumes(imgUUID, imgVolumes)
Line 3233: if spUUID and spUUID != sd.BLANK_UUID:
Why would you have a scenario where spUUID is None???
Line 3234: runImgPath = dom.linkBCImage(imgPath, imgUUID)
Line 3235: else:
Line 3236: runImgPath = imgPath
Line 3237:
--
To view, visit http://gerrit.ovirt.org/19825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Gadi Ickowicz <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
