Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Adding ppc64 handling to getVdsCaps
......................................................................
Patch Set 8:
(2 comments)
....................................................
File lib/vdsm/utils.py
Line 66:
Line 67:
Line 68: class Architecture:
Line 69: X86_64 = 'x86_64'
Line 70: PPC64 = 'ppc64'
Better postpone the definition to the same patch of usage. Only then we can
tell if the module makes sense.
Line 71:
Line 72:
Line 73: class IOCLASS:
Line 74: REALTIME = 1
....................................................
File tests/capsTests.py
Line 30: def testCpuInfo(self):
Line 31: testPath = os.path.realpath(__file__)
Line 32: dirName = os.path.split(testPath)[0]
Line 33: path = os.path.join(dirName, "cpu_info.out")
Line 34: c = caps.CpuInfo('x86_64', path)
The path argument is the only for testing. I can take an extra arg to
facilitate testing.
However, hopefully there's a cleaner way by monkeypatching platform.arch.
Line 35: self.assertEqual(set(c.flags()), set("""fpu vme de pse tsc msr
pae
Line 36: mce cx8 apic mtrr pge
mca
Line 37: cmov pat pse36 clflush
dts
Line 38: acpi mmx fxsr sse sse2
ss ht
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
