Dan Kenigsberg has posted comments on this change.
Change subject: Changing return method from vdsmd start function
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File init/sysvinit/vdsmd.init.in
Line 125: if [ "${is_coredump}" = "true" ]; then
Line 126: export DAEMON_COREFILE_LIMIT=unlimited
Line 127: echo "${CORE_DUMP_PATH}" > "${CORE_PATTERN}"
Line 128: fi
Line 129: shutdown_conflicting_srv "${CONFLICTING_SERVICES}" || return 1
good, there is a dormant bug in shutdown_conflicting_srv: if a conflicting
service is missing completely, that function (and now "start") would fail.
better fix it, too.
Line 130: start_needed_srv "${NEEDED_SERVICES}" || return 1
Line 131: "${VDSMD_INIT_COMMON}" --pre-start || return 1
Line 132:
Line 133: echo $"Starting up vdsm daemon: "
--
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
