Ayal Baron has posted comments on this change.
Change subject: iscsi: Iscsi rescan cleanup
......................................................................
Patch Set 11:
(2 comments)
....................................................
File vdsm/storage/iscsi.py
Line 391:
Line 392: log.debug("Performing SCSI scan, this will take up to %s seconds",
Line 393: maxTimeout)
Line 394:
Line 395: rescanOp = iscsiadm.session_rescan_async()
iscsiadm rescan does not hang for long periods of time afaik, so I'm not sure
what's the point of this here.
i.e. instead of all this fancy code, just remove this function and keep the
previous 'rescan' and possibly add a minWait sleep to it, to give the host some
time to add devices
Line 396: time.sleep(minTimeout)
Line 397: rescanOp.wait(timeout=(maxTimeout - minTimeout))
Line 398:
Line 399:
....................................................
File vdsm/storage/iscsiadm.py
Line 307: return AsyncProcessOperation(proc, parse_result)
Line 308:
Line 309:
Line 310: def session_rescan():
Line 311: aop = session_rescan_async()
did you mean apo? that's an implementation detail (that the object returned is
of AsyncProcessOperation type).
Line 312: return aop.result()
Line 313:
Line 314:
Line 315: def session_logout(sessionId):
--
To view, visit http://gerrit.ovirt.org/19256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
