Dan Kenigsberg has posted comments on this change.
Change subject: Removing unnecessary subshell call
......................................................................
Patch Set 1:
(1 comment)
....................................................
File init/sysvinit/vdsmd.init.in
Line 68: initctl stop "${srv}" || : # stop fails when already
down
Line 69: initctl status "${srv}" | grep -q stop/waiting
Line 70: elif [ -x "/etc/init.d/${srv}" ]; then
Line 71: ! service "${srv}" status >/dev/null 2>&1 ||
Line 72: service "${srv}" stop
negative logic confuses me. Any reason not to have
service "${srv}" status >/dev/null 2>&1 && service "${srv}" stop
?
Line 73: else
Line 74: true
Line 75: fi
Line 76: fi
--
To view, visit http://gerrit.ovirt.org/20061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a322836a82090671483f47a6a0c49878556a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
