Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ......................................................................
Patch Set 3: (1 comment) .................................................... File tests/functional/networkTests.py Line 1420: self.vdsm_net.setupNetworks(networks, {}, {}) Line 1421: Line 1422: self.assertTrue(os.path.isfile(hook_cookiefile)) Line 1423: Line 1424: delete_networks = {NETWORK_NAME: {'remove': True}} another nit: please avoid tabs. Line 1425: self.vdsm_net.setupNetworks(delete_networks, Line 1426: {}, {}) Line 1427: Line 1428: @cleanupNet -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelan...@ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelan...@ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches