Alon Bar-Lev has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool ......................................................................
Patch Set 2: (1 comment) .................................................... File lib/vdsm/tool/configurator.py Line 142: # libvirt configuration Line 143: if force: Line 144: for srv in libvirt_related_services: Line 145: try: Line 146: service.service_stop(srv) there must be some status verb that you can call before attempting to stop. Line 147: service_should_start.append(srv) Line 148: except service.ServiceOperationError: Line 149: # Means service is already stopped or not exists Line 150: pass -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
