Alon Bar-Lev has posted comments on this change.

Change subject: tests: Add monkey patching class decorator
......................................................................


Patch Set 1:

(2 comments)

....................................................
File tests/monkeypatch.py
Line 116:         return wrapper
Line 117:     return decorator
Line 118: 
Line 119: 
Line 120: #
up to here all above are cleanup, please separate these into separate non 
functional patch
Line 121: # Monkey patch class decorator.
Line 122: #
Line 123: # Usage:
Line 124: # ---


....................................................
File tests/monkeypatchTests.py
Line 19: #
Line 20: 
Line 21: from testrunner import VdsmTestCase
Line 22: 
Line 23: from monkeypatch import Patch, MonkeyPatch, MonkeyClass
this has nothing to do with patch, right?

and I am unsure it is better to use without prefix.
Line 24: 
Line 25: 
Line 26: class FakeModule:
Line 27: 


-- 
To view, visit http://gerrit.ovirt.org/20175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice429b01afaf00730ff59dcdf866ab5eeae6b926
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to