Allon Mureinik has posted comments on this change.
Change subject: iscsiadm: Add debug level option
......................................................................
Patch Set 1:
(2 comments)
....................................................
File lib/vdsm/config.py.in
Line 288: ('guests_gateway_ip', '', None),
Line 289:
Line 290: ]),
Line 291:
Line 292: # Section: [iscsiadm]
I wonder if this shouldn't be under [irs] like the other scsi and iscsi conf
values
Line 293: ('iscsiadm', [
Line 294:
Line 295: ('debug_level', '0',
Line 296: 'Print iscsiadm debugging information (0 - 8).'),
....................................................
File vdsm/storage/iscsiadm.py
Line 80: cmd = [constants.EXT_ISCSIADM]
Line 81:
Line 82: debug_level = config.get('iscsiadm', 'debug_level')
Line 83: if debug_level != '0':
Line 84: cmd.extend(('-d', debug_level))
where are stdout and stderr redirected to in this situation?
Line 85:
Line 86: cmd.extend(args)
Line 87:
Line 88: printCmd = None
--
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
