Sergey Gotliv has posted comments on this change.

Change subject: iscsiadm: Add debug level option
......................................................................


Patch Set 3:

>This change does not effect the clearness of vdsm log. It adds iscsi debug log 
>only if you enable this feature. 

So it does effect once you enable it. Do you know when and why it will happen? 
Did you try to debug non iscsiadm related issue when this log is turned on?

>If you need this information, the best place for it is in vdsm log where you 
>can understand the context of the command.

I am wondering why you don't want to move step by step, I mean writing this log 
to another file first. It probably will reduce the resistance to this RFE by 
half and you will be able to evaluate how helpful this log on the real customer 
environment.

I understand from that RFE (Lev's comment) that original problem was corrupted 
iscsi DB, do you know how it happened in the first place?

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to