Antoni Segura Puimedon has posted comments on this change.
Change subject: cleanup: Improve networking imports (PEP328)
......................................................................
Patch Set 1:
Thanks a lot for the review Nir!
>Important cleanup - but mixes many unrelated cleanups.
>
>This patch does much more than promised in the commit message:
>
> - Merge multiple imports into one line - this change is wrong, as it
> makes reviewing import changes harder. If you want to push this evil
> practice, do this in another patch.
I can very well move it to a separate patch so devs can vote on this
specific issue alone.
> - Change import order - not sure why this was done
I'll update the commit message to reflect that I'm fixing the imports in
general, and part of that is to keep them properly sorted.
> - Add missing copyright
Totally right, will move that into a separate patch.
> - Fix the years in another copyright
This is necessary for the patch. When you touch a file you are supposed to
make sure the the copyright is updated to include the current year in the
range.
>
>Please remove anything which is not related to absolute imports.
--
To view, visit http://gerrit.ovirt.org/20555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
