Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool ......................................................................
Patch Set 16: (1 comment) .................................................... File lib/vdsm/tool/configurator.py Line 24: Line 25: from vdsm import utils Line 26: import vdsm.tool Line 27: from vdsm.tool import service Line 28: from vdsm.constants import P_VDSM_EXEC, DISKIMAGE_GROUP I tend to agree with alon. although we might need the --force as it was, to reconfigure even if was configured.. can you think about such case? I dont.. Line 29: Line 30: Line 31: class _ModuleConfigure(object): Line 32: def __init__(self): -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
