Vinzenz Feenstra has posted comments on this change. Change subject: stats: return HA agent score when applicable ......................................................................
Patch Set 7: Code-Review-1 (1 comment) Besides that minor style issue with the logging it looks good to me. So just a minority -1 ;) .................................................... File vdsm/API.py Line 1220: try: Line 1221: stats['haScore'] = haClient.HAClient().get_local_host_score() Line 1222: except Exception: Line 1223: self.log.error("failed to retrieve Hosted Engine HA score", Line 1224: exc_info=True) self.log.exception("failed to retrieve Hosted Engine HA score") Without that exc_info=True, then it is logged as an error. Line 1225: Line 1226: return {'status': doneCode, 'info': stats} Line 1227: Line 1228: def setLogLevel(self, level): -- To view, visit http://gerrit.ovirt.org/20126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches