Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
......................................................................
Patch Set 19:
(2 comments)
....................................................
File init/systemd/systemd-vdsmd.in
Line 25:
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" configure ${2:+--force}
because legacy logic behavior is different.
legacy:
if --force or not configured:
vdsm-tool configure --force
vdsm-tool:
if not configured and not --force:
die if one of the service is up
configure
....................................................
File lib/vdsm/tool/configurator.py
Line 159:
Line 160: sanlock = SanlockModuleConfigure()
Line 161: c[sanlock.getName()] = sanlock
Line 162:
Line 163: __configurers = setConfigurers()
I prefer the third one...
for c in __configurers:
if c.getName() in modules:
now... I know this has the side effect of ignoring unsupported modules, but I
am fine with this as backward/forward compatibility is easier this way.
Line 164:
Line 165:
Line 166: @vdsm.tool.expose("configure")
Line 167: def configure():
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
