Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
......................................................................
Patch Set 25:
(2 comments)
....................................................
File lib/vdsm/tool/configurator.py
Line 122: raise UserWarning("Must run as root")
Line 123:
Line 124: rc, out, err = utils.execCmd(
Line 125: (
Line 126: '/usr/bin/usermod',
because you do not control where files are at, they can be at /usr/local or any
other place. but I know people here likes full paths so ignore me.
Line 127: '-a',
Line 128: '-G',
Line 129: 'qemu,kvm',
Line 130: 'sanlock'
Line 193:
Line 194: service_to_start = []
Line 195: for c in configurer_to_trigger:
Line 196: for s in c.getServices():
Line 197: if not service.service_status(s):
so fix this function...
Line 198: if not args.force:
Line 199: raise RuntimeError(
Line 200: "Cannot configure while %s is running" % s
Line 201: )
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
