Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
......................................................................
Patch Set 30:
(1 comment)
....................................................
File vdsm.spec.in
Line 733: supervdsmd_start_required='yes'
Line 734: fi
Line 735:
Line 736: %{_bindir}/vdsm-tool configure --force >/dev/null 2>&1
Line 737:
oh.. this is wrong .. it shouldn't force to reconfigure if already configured..
it should force restarting of related services, but not if already configured
which both are swallowed in the --force flag.
Line 738: if [ "${supervdsmd_start_required}" = 'yes' ]; then
Line 739: %{_bindir}/vdsm-tool service-start supervdsmd >/dev/null 2>&1
Line 740: fi
Line 741: if [ "${vdsmd_start_required}" = 'yes' ]; then
--
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
