Dan Kenigsberg has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol
......................................................................
Patch Set 12: Code-Review-1
(2 comments)
....................................................
File lib/vdsm/netinfo.py
Line 475: return network.get('bootproto', 'none')
Line 476:
Line 477: # Otherwise we need to search if the iface is the device for
a network
Line 478: for network, attributes in runningConfig.networks.iteritems():
Line 479: if iface in (attributes.get('nic'),
attributes.get('bonding')):
iface may be a vlan device, too.
Line 480: return attributes.get('bootproto', 'none')
Line 481: else:
Line 482: raise NotImplementedError
Line 483:
Line 476:
Line 477: # Otherwise we need to search if the iface is the device for
a network
Line 478: for network, attributes in runningConfig.networks.iteritems():
Line 479: if iface in (attributes.get('nic'),
attributes.get('bonding')):
Line 480: return attributes.get('bootproto', 'none')
would you make the 'return None' an explicit one?
Line 481: else:
Line 482: raise NotImplementedError
Line 483:
Line 484:
--
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
