Federico Simoncelli has uploaded a new change for review.
Change subject: sp: stop monitoring on detach storage domain
......................................................................
sp: stop monitoring on detach storage domain
As part of the monitoring implementation:
7b1cc6a Adding [start|stop]MonitoringDomain()
updateMonitoringThreads has been modified to assume that the list of
the monitored domains is the same as the list of the attached domains:
+ poolDoms = self.getDomains()
...
- for sdUUID in monitoredDomains:
+ for sdUUID in poolDoms:
if sdUUID not in activeDomains:
try:
self.domainMonitor.stopMonitoring(sdUUID)
This assumption is not valid when we are detaching a storage domain
(as it won't be listed by getDomains anymore). The resulting issue is
that the monitor domain thread is not stopped and the host id is left
acquired (ids file/device kept open by sanlock).
This patch adds a new specific stopMonitoring(sdUUID) call during the
detach storage domain flow in order to selectively stop the monitoring
of the relevant domain.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021557
Change-Id: I2c202720fc183ca0c194780c659bd25e3cac7e19
Signed-off-by: Federico Simoncelli <[email protected]>
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/21065/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 38cd453..a26e567 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1036,7 +1036,7 @@
if self.masterDomain.sdUUID == sdUUID:
self.stopSpm()
- self.updateMonitoringThreads()
+ self.domainMonitor.stopMonitoring(sdUUID)
self.log.debug("Force detach for domain `%s` is done", sdUUID)
def detachSD(self, sdUUID):
--
To view, visit http://gerrit.ovirt.org/21065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c202720fc183ca0c194780c659bd25e3cac7e19
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
