Dan Kenigsberg has posted comments on this change.

Change subject: remove irs_enable configuration attribute
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
Commit Message
Line 5: CommitDate: 2013-11-11 10:11:05 -0500
Line 6: 
Line 7: remove irs_enable configuration attribute
Line 8: 
Line 9: The configuration of vdsm included an attribute called 'irs_enable'
the commit message is not historically exact, as irs_enable existed before the 
SPM concept.

I love to delete dead code, but in this case, there may be a use case for 
running Vdsm without the storage subsystem (e.g. someone wants to use only its 
networking or fencing capabilities)
Line 10: which was supposed to make it possible to set a specific host as non
Line 11: eligible to serve as SPM.
Line 12: 
Line 13: This configuration is not supported (the engine will just try to


-- 
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to