Antoni Segura Puimedon has posted comments on this change.
Change subject: iproute2 ip link wrapper
......................................................................
Patch Set 11:
(3 comments)
....................................................
File lib/vdsm/ipwrapper.py
Line 127: range(0, len(tokens)-1, 2))
Line 128: return attrs
Line 129:
Line 130: @classmethod
Line 131: def fromText(cls, text, detection=True):
Doing it in fromText as a fallback mechanism is not that bad :P
Line 132: """Creates a Link object from the textual representation from
Line 133: iproute2's "ip -o -d link show" command."""
Line 134: attrs = cls._parse(text)
Line 135: if 'linkType' not in attrs:
....................................................
File lib/vdsm/utils.py
Line 947: sys.exit(-3)
Line 948:
Line 949:
Line 950: def pairwise(iterable):
Line 951: "s -> (s0,s1), (s1,s2), (s2, s3), ..."
Done
Line 952: a, b = itertools.tee(iterable)
Line 953: next(b, None)
Line 954: return itertools.izip(a, b)
Line 955:
....................................................
File tests/functional/networkTests.py
Line 1504: Link class."""
Line 1505: BIG_MTU = '2000'
Line 1506: VLAN_NAME = '%s.%s' % (BONDING_NAME, VLAN_ID)
Line 1507: with dummyIf(2) as nics:
Line 1508: with self.vdsm_net.pinger():
Done
Line 1509: status, msg = self.vdsm_net.setupNetworks(
Line 1510: {NETWORK_NAME:
Line 1511: {'bonding': BONDING_NAME, 'bridged': True,
Line 1512: 'vlan': VLAN_ID, 'mtu': BIG_MTU}},
--
To view, visit http://gerrit.ovirt.org/21054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
