Ayal Baron has posted comments on this change. Change subject: domainMonitor: tag pool monitored domains ......................................................................
Patch Set 2: Code-Review+2 (1 comment) .................................................... File vdsm/storage/domainMonitor.py Line 133: self.domainMonitor = domainMonitor Line 134: self.stopEvent = Event() Line 135: self.domain = None Line 136: self.sdUUID = sdUUID Line 137: self.hostId = hostId 1. You would have to override it in startMonitoring anyway as it can change (starting to monitor with monitorDomains and then calling connectStoragePool) so it would just be extra code but not extra functionality and very limited added clarity (in fact it might mislead one to think the default value is relevant at some point) 2. It is meaningless before we start monitoring anyway (as we only care about it in order to stop monitoring) Line 138: self.interval = interval Line 139: self.status = DomainMonitorStatus() Line 140: self.nextStatus = DomainMonitorStatus() Line 141: self.isIsoDomain = None -- To view, visit http://gerrit.ovirt.org/21165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71714b24b7c8bbb437cbb2e8e254690215df020a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
