Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
......................................................................
Patch Set 16:
(1 comment)
....................................................
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: "$VDSM_TOOL" lvm-deactivate-lvs
Line 184: }
The tests check the calls more than the lvm itself, like the parameters we send
to the lvm command and the guard logic.. it may be nice to have those and it
will fail if someone will decide to change it. although, if someone decides to
change the cmd parameters because lvm was changed, now he'll just need to
modify it in two locations.
it doesn't test more except the parameter you except to get and the output you
except to get if specific parameters were sent.. or am i missing something
there?
Line 185: #### pre-start tasks end ####
Line 186:
Line 187:
Line 188: #### post-stop tasks ####
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
