Martin Polednik has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom ......................................................................
Patch Set 5: (1 comment) .................................................... File vdsm/clientIF.py Line 300: Line 301: # leave path == '' for empty cdrom and floppy drives ... Line 302: elif (drive['device'] in ('cdrom', 'floppy') and Line 303: 'specParams' in drive and Line 304: # next line can be removed in future, when < 3.3 engine The problem is that we are not 100% sure, but as far as I understand according to code in http://gerrit.ovirt.org/#/c/2943/ there is still a possibility of receiving such path - I'd rather live with temporary ugly but safe code than breaking anything. Line 305: # is not supported Line 306: drive.specParams.get('path', '') == '' and Line 307: drive.get('path', '') == ''): Line 308: volPath = '' -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches