Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
......................................................................
Patch Set 1:
(1 comment)
....................................................
File init/vdsmd_init_common.sh.in
Line 54: }
Line 55:
Line 56:
Line 57: task_reconfigure_libvirt(){
Line 58: "$VDSM_TOOL" libvirt-configure | grep -q 'To start working' &&
return 1
its much easier with returnig different error code (no need for new echo, or
even any change here). if you don't see how it can brake anything, and I can't
either, lets propose it that way
Line 59: return 0
Line 60: }
Line 61:
Line 62:
--
To view, visit http://gerrit.ovirt.org/21356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
