Dan Kenigsberg has posted comments on this change.
Change subject: netinfo/sampling: split speed into nic and bond specific methods
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
....................................................
File lib/vdsm/netinfo.py
Line 212: else:
Line 213: paths = (BONDING_OPT % (bond, key) for key in keys)
Line 214: opts = {}
Line 215: for path in paths:
Line 216: with open(path) as optFile:
please remember to fix bondOpts so that an empty string translates to an empty
list, not to [''].
Line 217: opts[os.path.basename(path)] =
optFile.read().rstrip().split(' ')
Line 218: return opts
Line 219:
Line 220:
--
To view, visit http://gerrit.ovirt.org/21542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
