Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism ......................................................................
Patch Set 14: Code-Review-1 (3 comments) .................................................... File lib/vdsm/utils.py Line 103: return stat.S_ISBLK(os.stat(path).st_mode) Line 104: Line 105: Line 106: def touchFile(filePath, ignoreExceptions=False): Line 107: """ ohh love it, Thanks! :) but.. can you please separate this to another patch and I'll comment there? Line 108: Subset of POSIX touch functionality Line 109: :param filePath: The file to touch Line 110: :param ignoreExceptions: Should file handling exceptions be ignored? Line 111: """ .................................................... File vdsm/logger.conf.in Line 1: [loggers] Line 2: keys=root,vds,Storage,metadata you need to define your new logger Line 3: Line 4: [handlers] Line 5: keys=console,syslog,logfile,metadata Line 6: Line 1: [loggers] Line 2: keys=root,vds,Storage,metadata Line 3: Line 4: [handlers] Line 5: keys=console,syslog,logfile,metadata and your new handler.. Line 6: Line 7: [formatters] Line 8: keys=long,simple,none,sysform Line 9: -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
