Federico Simoncelli has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
The patch seems more or less ok to me. But I am really (really, really) worried
about this entire part of the code. If there's any chance that we can make it
better instead of just adding a new state... it would be great.
....................................................
File vdsm/BindingXMLRPC.py
Line 983:
Line 984: # Ready to show the log into vdsm.log
Line 985: f.im_self.log.log(logLevel, logStr)
Line 986:
Line 987: if f.im_self.cif.ready:
Can we get a consult from Saggi here? This looks misplaced. It should be
consistent across all the bindings (xmlrpc/json).
Line 988: res = f(*args, **kwargs)
Line 989: else:
Line 990: res = errCode['recovery']
Line 991: f.im_self.cif.log.log(logLevel, 'return %s with %s',
....................................................
File vdsm/clientIF.py
Line 255: self.irs = None
Line 256: if config.getboolean('irs', 'irs_enable'):
Line 257: try:
Line 258: self.irs = Dispatcher(HSM())
Line 259: except:
Does this mean that we allow VDSM to start and run even without having a way to
communicate with it?
Can we get rid of the old (and maybe unused) irs_enable?
Line 260: self.log.error("Error initializing IRS",
exc_info=True)
Line 261: else:
Line 262:
self.irs.registerDomainStateChangeCallback(self.contEIOVms)
Line 263:
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
