Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
......................................................................
Patch Set 2:
(3 comments)
....................................................
File client/vdsClient.py
Line 245: params = {'vmId': args[0], 'drive': drive}
Line 246: return self.ExecAndExit(self.s.hotunplugDisk(params))
Line 247:
Line 248: def setNumberOfCpus(self, args):
Line 249: return self.ExecAndExit(self.s.setNumberOfCpus(args[0],
args[1]))
you can do just *args
Line 250:
Line 251: def do_changeCD(self, args):
Line 252: vmId = args[0]
Line 253: file = self._parseDriveSpec(args[1])
....................................................
File vdsm/API.py
Line 456: def setNumberOfCpus(self, params):
Line 457: try:
Line 458: utils.validateMinimalKeySet(params, ('vmId',
'numberOfCpus'))
Line 459: except ValueError:
Line 460: self.log.error('Missing one of required parameters: vmId,
drive')
better to add backtrace print also.. no?
Line 461: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 462: 'message': 'Missing one of required '
Line 463: 'parameters: vmId,
numberOfCpus'}}
Line 464: try:
....................................................
File vdsm_api/vdsmapi-schema.json
Line 6694: #
Line 6695: # Since: 4.10.0
Line 6696: ##
Line 6697: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6698: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int' },
whitespace after 'init', I think it fails the validation of the scheme
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
