Ayal Baron has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. ......................................................................
Patch Set 2: (1 comment) .................................................... File vdsm/storage/hsm.py Line 2726: # getSharedLock(connectionsResource...) Line 2727: Line 2728: vars.task.getSharedLock(STORAGE, sdUUID) Line 2729: info = dom.getInfo() Line 2730: # This only occurred because someone As far as I can see engine never read this part of the info. As you wrote in the commit message, getStorageDomainInfo should not return pool info. I could not agree more. Pending a bit testing, I see no reason why not to just delete lines 2730 - 2767 here (everything regarding the pool). Line 2731: # thought it would be clever to return pool Line 2732: # information in the domain.getInfo() method Line 2733: # In a perfect world I would have just stopped Line 2734: # giving this information in the response. -- To view, visit http://gerrit.ovirt.org/19555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Aharon Canan <aharo...@gmail.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Elad Ben Aharon <eladba1...@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Gadi Ickowicz <gicko...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
