Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Minor nits remain. Please add yourself as an AUTHOR, too.
....................................................
File vdsm.spec.in
Line 1055: %{python_sitearch}/%{vdsm_name}/define.py*
Line 1056: %{python_sitearch}/%{vdsm_name}/exception.py*
Line 1057: %{python_sitearch}/%{vdsm_name}/ipwrapper.py*
Line 1058: %{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
Line 1059: %{python_sitearch}/%{vdsm_name}/netinfo.py*
Intentional?
Line 1060:
Line 1061: %{python_sitearch}/%{vdsm_name}/qemuImg.py*
Line 1062: %{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
Line 1063: %{python_sitearch}/%{vdsm_name}/netconfpersistence.py*
....................................................
File vdsm/Makefile.am
Line 31: clientIF.py \
Line 32: configNetwork.py \
Line 33: debugPluginClient.py \
Line 34: dmidecodeUtil.py \
Line 35: ppc64HardwareInfo.py \
Please keep sorted.
Line 36: guestIF.py \
Line 37: hooking.py \
Line 38: hooks.py \
Line 39: kaxmlrpclib.py \
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Better Saggi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
