Antoni Segura Puimedon has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
......................................................................
Patch Set 3:
(2 comments)
....................................................
File init/vdsmd_init_common.sh.in
Line 200: return 0
Line 201: }
Line 202:
Line 203: task_upgrade_300_nets(){
Line 204: "$VDSM_TOOL" upgrade-3.0.0-networks
I agree with Dan. Better catch and stop.
Line 205: }
Line 206: #### pre-start tasks end ####
Line 207:
Line 208:
....................................................
File lib/vdsm/tool/upgrade_300_networks.py
Line 26: from vdsm.tool import expose
Line 27: from vdsm.tool.upgrade import Upgrade
Line 28:
Line 29: sys.path.append("/usr/share/vdsm")
Line 30: from netconf import ifcfg
Rather the opposite should happen. And vdsm-tool should reside in P_VDSM anyway.
Line 31:
Line 32:
Line 33: def isNeeded(networks, bridges):
Line 34: return (MANAGEMENT_NETWORK not in networks and
--
To view, visit http://gerrit.ovirt.org/20803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb2ffff1715dc3b92fc6c198dbb4c49f0bbef0cb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
