Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
......................................................................
Patch Set 17: Code-Review+2
(1 comment)
....................................................
File lib/vdsm/tool/upgrade.py
Line 81: def _editOtherLoggers(self, edit):
Line 82: """
Line 83: add/remove upgrade handler to/from all non-upgrade loggers
Line 84: """
Line 85: loggers = dict(logging.Logger.manager.loggerDict.items() +
Seems like an overkill to me, but let it be.
Line 86: [('root', logging.getLogger())])
Line 87: for name, logger in loggers.iteritems():
Line 88: if name != 'upgrade':
Line 89: for handler in logging.getLogger('upgrade').handlers:
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
