Liron Ar has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value ......................................................................
Patch Set 3: (1 comment) .................................................... File vdsm/storage/domainMonitor.py Line 41: self.clear() Line 42: Line 43: def clear(self): Line 44: self.error = None Line 45: self.checked = False The cost isn't the main issue (although it's nice to save even a bit :-) ), the issue IMO is that it makes more sense that the monitoring thread will hold the boolean indicating whether it executed the check already, not the status that "shouldn't" have knowledge about it but should only hold the results. Line 46: self.lastCheck = time() Line 47: self.valid = True Line 48: self.readDelay = 0 Line 49: self.diskUtilization = (None, None) -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee0333354146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
