Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22213
to review the following change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
......................................................................
hsm: Log unhandled exceptions in storage refresh thread
hsm's storage refresh background thread does not handle exceptions,
making it harder then it should to debug stupid errors in underlying
calls or debug real errors in the field.
This patch log a traceback for unhandled exceptions so it will never die
silently again.
Change-Id: I2e69464ba27b7d522c5ceb3a3099949efe7fbc88
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/21486
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/22213/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index a91ae92..1d36cee 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -370,6 +370,7 @@
except Exception:
self.log.warn("Failed to clean Storage Repository.", exc_info=True)
+ @utils.traceback(on=self.log.name)
def storageRefresh():
lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
sdCache.refreshStorage()
--
To view, visit http://gerrit.ovirt.org/22213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e69464ba27b7d522c5ceb3a3099949efe7fbc88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
