Yaniv Bronhaim has posted comments on this change.

Change subject: sanlock isconfigured raises an exception instead of returning 
result
......................................................................


Patch Set 4:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 138: 
Line 139:     def isconfigured(self, *args):
Line 140:         """
Line 141:         True if sanlock service requires a restart to reload the 
relevant
Line 142:         supplementary groups.
damn.. good catch :P
Line 143:         """
Line 144:         ret = False
Line 145:         try:
Line 146:             with open("/var/run/sanlock/sanlock.pid", "r") as f:


-- 
To view, visit http://gerrit.ovirt.org/22184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to