Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Reboot capability for VM ......................................................................
Patch Set 37: (2 comments) .................................................... File vdsm/vm.py Line 1729: self.timeout = max(0, timeout) Line 1730: self.force = force Line 1731: Line 1732: def start(self): Line 1733: try: Please do. I'd want shutdown() to explode if it has a bug, not randomly continue. Line 1734: self._setGuestEvent() Line 1735: # are there any available methods for shutdown/reboot? Line 1736: if self.chain.callbacks: Line 1737: self.chain.start() Line 1764: # flag for successful power-down event detection Line 1765: # this flag is common for both shutdown and reboot workflows Line 1766: # because we want to exit the CallbackChain in case either Line 1767: # of them happens Line 1768: vm._powerDownEvent.clear() To bad that I missed that discussion. I have an old resentment to the command pattern - see Engine to understand why. Could you direct me to where you were convinced to use it here? Line 1769: if reboot: Line 1770: desc = {'action': 'Reboot', Line 1771: 'guestEvent': 'RebootInProgress', Line 1772: 'returnMsg': 'Machine rebooting'} -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Better Saggi <bettersa...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches