Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................
Patch Set 5:
(2 comments)
Nir,
Let's wait to see what others think about this patch.
I easily see 2 different subjects in this patch so I can split it if needed.
....................................................
File vdsm/vm.py
Line 81:
Line 82:
Line 83: def isVdsmImage(drive):
Line 84: if hasattr(drive, "isVdsmImage"):
Line 85: return drive.isVdsmImage()
Sounds reasonable to align both these methods.
Line 86: elif type(drive) is dict:
Line 87: return all(k in drive.keys() for k in ('volumeID', 'domainID',
Line 88: 'imageID', 'poolID'))
Line 89: else:
Line 82:
Line 83: def isVdsmImage(drive):
Line 84: if hasattr(drive, "isVdsmImage"):
Line 85: return drive.isVdsmImage()
Line 86: elif type(drive) is dict:
Good point.
Line 87: return all(k in drive.keys() for k in ('volumeID', 'domainID',
Line 88: 'imageID', 'poolID'))
Line 89: else:
Line 90: return False
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
