Yaniv Bronhaim has submitted this change and it was merged.

Change subject: threadPool: Do not keep reference to tasks
......................................................................


threadPool: Do not keep reference to tasks

Worker thread was taking a task from the threadpool queue, run it, and
then hold it until the next task is run. This causes the task and all
objects referenced from it to keep living until the next task is run by
this thread.

This patch ensure that worker thread does not keep referece to tasks
after they were run.

Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58
Relates-To: https://bugzilla.redhat.com/1032925
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22136
Reviewed-by: Ayal Baron <aba...@redhat.com>
Reviewed-by: Allon Mureinik <amure...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22208
Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com>
Tested-by: Yaniv Bronhaim <ybron...@redhat.com>
---
M vdsm/storage/threadPool.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to