Dan Kenigsberg has posted comments on this change. Change subject: Run pinger in separate process ......................................................................
Patch Set 2: (2 comments) .................................................... File tests/functional/ping.py Line 1: import time Line 2: from vdsm import vdscli Line 3: Line 4: client = vdscli.connect() actually, this script is the client, and vdscli.connect() is the (proxy for the) server. Line 5: Line 6: try: Line 7: while True: Line 8: client.ping() .................................................... File tests/functional/utils.py Line 175: @contextmanager Line 176: def pinger(self): Line 177: """Keeps pinging vdsm for operations that need it""" Line 178: path = os.path.join(os.path.dirname(__file__), 'ping.py') Line 179: pinger = utils.execCmd([constants.EXT_PYTHON, path], sync=False) multiprocessing has its issues, but I suppose that using it could have simplified this patch (/me is not sure about it). Line 180: try: Line 181: yield Line 182: finally: Line 183: pinger.kill() -- To view, visit http://gerrit.ovirt.org/22293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92719ef4a2673ed874fa47a9acbc1e7028bb7197 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches