Sergey Gotliv has posted comments on this change. Change subject: clientIF: Remove unnecessary device is disk check ......................................................................
Patch Set 1: (1 comment) I will improve the commit message later. .................................................... File vdsm/clientIF.py Line 243: Line 244: def prepareVolumePath(self, drive, vmId=None): Line 245: if type(drive) is dict: Line 246: # PDIV drive format Line 247: if vm.isVdsmImage(drive): This block should check only PDIV, there is no need to check device type. More than that if this is a PDIV => this is a disk at least right for today Line 248: res = self.irs.prepareImage( Line 249: drive['domainID'], drive['poolID'], Line 250: drive['imageID'], drive['volumeID']) Line 251: -- To view, visit http://gerrit.ovirt.org/22363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
