Sergey Gotliv has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool ......................................................................
Patch Set 8: (1 comment) .................................................... File vdsm/storage/hsm.py Line 1028: pass # pool not connected yet Line 1029: else: Line 1030: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared): Line 1031: self.getPool(spUUID).update(hostID, scsiKey, msdUUID, Line 1032: masterVersion) I enjoyed reviewing it so this is not the waste of the time :-). I will find a bug later so you can refer you new patch to it. Line 1033: return True Line 1034: Line 1035: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive): Line 1036: try: -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
